Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of selectsRange back to a boolean #5029

Open
mstrom20 opened this issue Aug 6, 2024 · 1 comment
Open

Change type of selectsRange back to a boolean #5029

mstrom20 opened this issue Aug 6, 2024 · 1 comment

Comments

@mstrom20
Copy link

mstrom20 commented Aug 6, 2024

Is your feature request related to a problem? Please describe.
I have installed the update to v7.x.x, and I noticed the type for the option selectsRange changed from a boolean to "true"-only. This makes optional and dynamic prop-filling more inconvenient for consuming libraries.

Describe the solution you'd like
old:
{ selectsRange: never, ... } & { selectsRange: true, ... }

proposed:
{ selectsRange: boolean, ... }

@dlpmmk
Copy link

dlpmmk commented Aug 10, 2024

I agree

nmpavel pushed a commit to nmpavel/react-datepicker that referenced this issue Aug 28, 2024
…tsRange type to boolean instead of never & true]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants