Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin manager will not install plugins from a scoped repository #106

Open
johnnygf opened this issue Jan 24, 2020 · 0 comments
Open

Plugin manager will not install plugins from a scoped repository #106

johnnygf opened this issue Jan 24, 2020 · 0 comments

Comments

@johnnygf
Copy link

It was discovered when a version of a private gitbook plugin that had a new version that was scoped was not being used in the gitbook and the old version that was not scoped was being used.

That is: @foo/gitbook-plugin-theme-awesome was specified in our gitbook's package.json, but book.json had theme-awesome and the gitbook installer would only prepend gitbook-plugin, so even though npm/yarn had installed @foo/gitbook-plugin-theme-awesome gitbook's plugin installer looked for gitbook-plugin-theme-awesome, didn't find it locally and installed the old version of gitbook-plugin-theme-awesome.

Obviously there is a workaround that involves moving the scoped version up to node_modules and renaming it in its package.json as part of the install/build script, but is there some other solution whereby book.json could refer to the plugin's full npm name instead of the gitbook plugin installer only prepending gitbook-plugin- to the short name?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant