Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S3 integration tests are never run #1206

Open
groldan opened this issue Jan 5, 2024 · 1 comment
Open

S3 integration tests are never run #1206

groldan opened this issue Jan 5, 2024 · 1 comment

Comments

@groldan
Copy link
Member

groldan commented Jan 5, 2024

About half the tests for the gwc-aws-s3 blobstore module are integration tests that are never run on Github Actions nor on Jenkins.

mvn verify -o -pl :gwc-aws-s3 2> /dev/null | grep "Tests run" | tail -n 1
[WARNING] Tests run: 54, Failures: 0, Errors: 0, Skipped: 45

This might be due to the difficulty of having an actual AWS S3 bucket to test against. All these tests get ignored and print out a warning message. E.g.:

[INFO] Running org.geowebcache.s3.S3BlobStoreConformanceTest
INFO      org.geowebcache.s3.PropertiesLoader - Loading S3 tests config. File must have keys 'bucket', 'accessKey', and 'secretKey'
WARNING   org.geowebcache.s3.PropertiesLoader - S3 storage config file not found. GWC S3 tests will be ignored. /home/groldan/.gwc_s3_tests.properties
INFO      org.geowebcache.s3.PropertiesLoader - Loading S3 tests config. File must have keys 'bucket', 'accessKey', and 'secretKey'
WARNING   org.geowebcache.s3.PropertiesLoader - S3 storage config file not found. GWC S3 tests will be ignored. /home/groldan/.gwc_s3_tests.properties
...
@aaime
Copy link
Member

aaime commented Apr 18, 2024

I guess the tests could be run against a local Minio instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants