Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minified stack trace source map resolution doesn't work on desktop #4404

Open
cmdcolin opened this issue May 29, 2024 · 1 comment
Open

Minified stack trace source map resolution doesn't work on desktop #4404

cmdcolin opened this issue May 29, 2024 · 1 comment
Labels
bug Something isn't working housekeeping needs to be tidied up, is a drag on team performance

Comments

@cmdcolin
Copy link
Collaborator

Example:
Follow steps from #4403, get the 512Mb error, and click the "Show source map" and it will not work

will show something like

Error: Data exceeds maximum string length (512MB)

    at l.loadDataP (file:///Applications/JBrowse%202.app/Contents/Resources/app.asar/build/static/js/7809.b1b86892.chunk.js:1:493)
    at async l.getRefNames (file:///Applications/JBrowse%202.app/Contents/Resources/app.asar/build/static/js/7809.b1b86892.chunk.js:1:1263)

similar for linux appimage, not sure about windows

it would be a 'nice to have' to improve these stack traces, but it would require some method to figure out how to read the on-disk .map files (the "show stack trace" currently assumes a fetch against remote server for those resources. sometimes "fetch against the filesystem" works in electron in some cases, and not sure exactly the case but maybe not embedded in the app resources or not with certain permissions set)

@cmdcolin cmdcolin added bug Something isn't working housekeeping needs to be tidied up, is a drag on team performance labels May 29, 2024
@cmdcolin
Copy link
Collaborator Author

following same steps on web the error gives you the actual file name and line number

Error: Data exceeds maximum string length (512MB)
../../../plugins/gff3/src/Gff3Adapter/Gff3Adapter.ts:30:13

JBrowse 2.11.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working housekeeping needs to be tidied up, is a drag on team performance
Projects
None yet
Development

No branches or pull requests

1 participant