hidewearablesoftype does not hide hair when hidelimb is true

[itchyOwl]

Discussed in #14688

^{Originally posted by 4-S-H September 23, 2024}
Might be related to #11562;

Code of the wearable (the sprite is transparent):

<Wearable limbtype="Head" slots="Any,Headset" msg="ItemMsgPickUpSelect" displaycontainedstatus="true">
  <sprite name="mod_Head" texture="%ModDir%/images.png" limb="Head" hidelimb="true" inheritlimbdepth="true" ignorelimbscale="true" hidewearablesoftype="Moustache,Beard,Hair,FaceAttachment,Husk,Herpes" sourcerect="0,0,256,256" origin="0.5,0.5" />
</Wearable>

Appearance of the head without the wearable:

with the wearable and hidelimb=false:

with the wearable and hidelimb=true:

The code here might be responsible: when the if check on line 891 succeeds and the one on line 893 fails, the original hair sprite is drawn even though it should be hidden.

Barotrauma/Barotrauma/BarotraumaClient/ClientSource/Characters/Limb.cs

Lines 886 to 908 in 0e8fb65

	foreach (WearableSprite wearable in OtherWearables)
	{
	if (wearable.Type == WearableType.Husk) { continue; }
	if (wearableTypesToHide.Contains(wearable.Type))
	{
	if (wearable.Type == WearableType.Hair)
	{
	if (HairWithHatSprite != null && !hideLimb)
	{
	DrawWearable(HairWithHatSprite, depthStep, spriteBatch, blankColor, alpha: color.A / 255f, spriteEffect);
	depthStep += step;
	continue;
	}
	}
	else
	{
	continue;
	}
	}
	DrawWearable(wearable, depthStep, spriteBatch, blankColor, alpha: color.A / 255f, spriteEffect);
	//if there are multiple sprites on this limb, make the successive ones be drawn in front
	depthStep += step;
	}