Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in correlating modules #176

Open
zhujun98 opened this issue Apr 27, 2020 · 1 comment
Open

Bug in correlating modules #176

zhujun98 opened this issue Apr 27, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@zhujun98
Copy link
Collaborator

The data transformer currently does not match modules under a data source. For example, if the source is a multi-module detector like SPB_IRDA_JNGFR/DET/MODULE_*:daqOutput and the data is streamed from files with the "random shuffle" mode. The assembled image will be displayed with one module each time. In other word, a train will be processed multiple times, each time with a single module.

@zhujun98 zhujun98 added the bug Something isn't working label Apr 27, 2020
@zhujun98
Copy link
Collaborator Author

zhujun98 commented May 5, 2020

For now, this is only a problem for streaming from files. The root cause is that stack_detector_modules uses regex to find the matched modules and EXtra-foam simply uses the source name * as the aggregated source name. As for the generalized geometry, this does not work since the detector module number can be something like [1, 2, 3, 6, 7, 8], in which case the module index must be provided explicitly. All in all, the solution for this is to re-implement "stack_detector_modules": should need "stack_1M_detector_modules" and "stack_jf_detector_modules" for now. Then use the module name as the first level source name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant