Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract methods #7

Open
Eneroth3 opened this issue Mar 31, 2018 · 2 comments
Open

Extract methods #7

Eneroth3 opened this issue Mar 31, 2018 · 2 comments

Comments

@Eneroth3
Copy link
Owner

SolidOperations has become a very large class, with a lot of private methods that can be extracted to a library, such as Eneroth3/sketchup-community-lib.

Remember to re-enable RuboCop Metrics/ModuleLength if extracting these methods.

Methods already in cmty-lib:

  • definition
  • instance?
  • transform_as_normal
  • transpose
  • wrapping_face

Methods that could be added to cmty-lib:

  • uniq_points -> LGeom.purge_duplicates (or perhaps LArray.uniq_equals)
  • within_face? -> LFace -> point_within?
  • point_at_face -> LFace.arbitrary_point_within

Methods that could be moved to a SelectEntities class, specific to solid operations:

These are a bit too specific to this implementation to fit into the API of a public library.

  • find_faces
  • find_corresponding_faces
  • find_coplanar_edges
  • naked_edges
  • find_mesh_geometry

purge redundant find_-prefix if doing so

@Eneroth3
Copy link
Owner Author

Eneroth3 commented Apr 2, 2018

Methods already in cmty-lib:

  • icon_file_extension

@Eneroth3
Copy link
Owner Author

Eneroth3 commented Apr 2, 2018

Started extract-methods branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant