Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLN API deprecation causes peerswap-listpeers field to disappear #194

Open
grubles opened this issue Jun 13, 2023 · 1 comment
Open

CLN API deprecation causes peerswap-listpeers field to disappear #194

grubles opened this issue Jun 13, 2023 · 1 comment
Labels
deprecated cln api Related to CLN API deprecations
Milestone

Comments

@grubles
Copy link
Collaborator

grubles commented Jun 13, 2023

CLN v23.05 with allow-deprecated-apis=false and PeerSwap at 19aaf19

peerswap-listpeers is missing the channels field. Commenting out allow-deprecated-apis=false fixes it, so it appears we might have missed a deprecation.

$ lightning-cli --signet peerswap-listpeers
[
   {
      "nodeid": "...",
      "swaps_allowed": true,
      "supported_assets": [
         "btc",
         "lbtc"
      ],
      "channels": [],
      "sent": {
         "total_swaps_out": 19,
         "total_swaps_in": 15,
         "total_sats_swapped_out": 2700200000,
         "total_sats_swapped_in": 2090100000
      },
      "received": {
         "total_swaps_out": 6,
         "total_swaps_in": 6,
         "total_sats_swapped_out": 600000000,
         "total_sats_swapped_in": 600000000
      },
      "total_fee_paid": 9293
   }
]
@nepet
Copy link
Contributor

nepet commented Jun 13, 2023

Oh yes this going to be removed in v23.11 So for now, running with allow-deprecated-apis=true is an option. This is something that I need to include into glightning before I can adapt the change in the PeerSwap cln plugin.

@wtogami wtogami added this to the v1.1 milestone Jul 18, 2023
@grubles grubles added the deprecated cln api Related to CLN API deprecations label Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated cln api Related to CLN API deprecations
Projects
None yet
Development

No branches or pull requests

3 participants