Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "facets" keyword argument to DatasetResult.file_context #80

Open
alaniwi opened this issue Dec 2, 2021 · 0 comments
Open

add "facets" keyword argument to DatasetResult.file_context #80

alaniwi opened this issue Dec 2, 2021 · 0 comments

Comments

@alaniwi
Copy link
Collaborator

alaniwi commented Dec 2, 2021

The DatasetResult.file_context function (see results.py) doesn't allow a facets keyword argument, but we might want to set the facets property of the FileSearchContext object that is returned (especially in order to avoid the default facets='*').

Currently we have to monkey-patch it:

fc = result.file_context()
fc.facets = 'project'

but it would be nice to be able to do:

fc = result.file_context(facets='project')

Should be a simple fix to just add the argument and pass it through.

@alaniwi alaniwi changed the title add "facets" keyword argument to file_context() add "facets" keyword argument to DatasetResult.file_context Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant