-
Notifications
You must be signed in to change notification settings - Fork 138
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CAM history erroneously overrides averaging flags for nhtfrq=1 #1150
Comments
This happened in #903, see this comment. |
Is there a way to query how many times an outfld call for a particular variable is called in a time-step? If we could get this number N than we could make logic that, for this special case of |
I would vote for a new, optional input to |
One complication with that approach is I could set up the namelists to do no subcycling -- e.g, for ne240pg3, we don't subcycle in the macmic loop at all. |
Of course but is that a bad thing? What is the impact of allowing averaging (or other collection methods) for this case? Is there an impact beyond the timestamp being in the middle of the time step instead of the current time (lines 5816 - 5822) in cam_history.F90)? |
I don't know if there's an adverse impact other than creating inconsistent time metadata relative to the non-subcycled variables in this case, but I agree this is preferable to the current method. |
What happened?
If nhtfrq=1, CAM history currently overrides (since cam6_3_140) the averaging flag to 'I'
BUT:
as @adamrher pointed out, this neglects subcycling averages.
What are the steps to reproduce the bug?
Run CAM, outputting a variable that exists in a subcycle (like a CLUBB variable in the macmic loop) with the 'A' flag and observe that the results are the same as for the 'I' flag.
What CAM tag were you using?
cam6_4_032
What machine were you running CAM on?
CGD machine (e.g. izumi)
What compiler were you using?
GNU
Path to a case directory, if applicable
No response
Will you be addressing this bug yourself?
Any CAM SE can do this
Extra info
No response
The text was updated successfully, but these errors were encountered: