Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set logical before printing thermodynamically active species in air_composition #303

Open
peverwhee opened this issue Sep 23, 2024 · 0 comments
Labels
bug Something isn't working correctly

Comments

@peverwhee
Copy link
Collaborator

What happened?

Right now, we're printing out Thermodynamic active species information for every constituent, regardless of whether it's actually thermodynamically active

src/data/air_composition.F90: line ~434

What are the steps to reproduce the bug?

Add a new constituent via the metadata (advected = true) that is not in the case select for thermodynamically active species in air_composition.F90.

Then see that that constituent is listed in the atm.log under "Thermodynamic active species "

What CAM-SIMA hash were you using?

c99c034

What machine were you running CAM-SIMA on?

CGD machine (e.g. izumi)

What compiler were you using?

GNU

Path to a case directory, if applicable

No response

Will you be addressing this bug yourself?

Any Software Engineer can do this

Extra info

What we need is a logical that defaults to .false. and is set to true only if one of the case selects is entered. And then the writing to iulog should only happen for iterations when the logical is .true.

@peverwhee peverwhee added the bug Something isn't working correctly label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

No branches or pull requests

1 participant