Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema Validation errors not shown in UI #1006

Open
2 tasks done
stephan-wolf-ais opened this issue Sep 17, 2024 · 2 comments
Open
2 tasks done

Schema Validation errors not shown in UI #1006

stephan-wolf-ais opened this issue Sep 17, 2024 · 2 comments
Labels
defect Something isn't working good first issue Good for newcomers hacktoberfest Issues eligible for Hacktoberfest contributions p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort

Comments

@stephan-wolf-ais
Copy link

Current Behavior

Upon invalid bom upload an error message is shown as shown

image

Steps to Reproduce

  1. upload an invalid bom

Expected Behavior

the error message from the result should be shown as well

i.e. errors from the result json like this:

{
"status": 400,
"title": "The uploaded BOM is invalid",
"detail": "Schema validation failed",
"errors": [
"$.metadata.timestamp: does not match the date-time pattern must be a valid RFC 3339 date-time"
]
}

Dependency-Track Frontend Version

4.7.x

Browser

Google Chrome

Browser Version

No response

Operating System

Linux

Checklist

@stephan-wolf-ais stephan-wolf-ais added defect Something isn't working in triage labels Sep 17, 2024
@nscuro
Copy link
Member

nscuro commented Sep 17, 2024

This is somewhat on purpose, because the screen real estate of the popups is very small, but validation failure messages are long. Also, large BOMs with many i valid entries amplify this issue.

I guess the main challenge is to find another way to display all validation errors, in a way that is not purely limited by screen space.

@nscuro nscuro added p2 Non-critical bugs, and features that help organizations to identify and reduce risk good first issue Good for newcomers size/S Small effort and removed in triage labels Sep 17, 2024
@stephan-wolf-ais
Copy link
Author

An idea could be an upload dialog including i.e. a progress bar for the upload process and a textbox to show the result of the upload request. This would also be helpfull for large bom files

@leec94 leec94 added the hacktoberfest Issues eligible for Hacktoberfest contributions label Sep 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working good first issue Good for newcomers hacktoberfest Issues eligible for Hacktoberfest contributions p2 Non-critical bugs, and features that help organizations to identify and reduce risk size/S Small effort
Projects
None yet
Development

No branches or pull requests

3 participants