Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readability of larndsim #227

Open
YifanC opened this issue May 9, 2024 · 0 comments
Open

Readability of larndsim #227

YifanC opened this issue May 9, 2024 · 0 comments

Comments

@YifanC
Copy link
Collaborator

YifanC commented May 9, 2024

I think one of the reason larndsim readability is low is that when we define intermediate data, we uses shape of previous intermediate data, for example here (instead of using len(unique_pix), we use pixels_signals.shape[0])

Suggestions:

  1. Add comments
  2. Explicitly define the intermediate data type
  3. Enforce consistency check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant