Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardise the Engine Json RPC error codes #8671

Open
mehdi-aouadi opened this issue Oct 2, 2024 · 0 comments
Open

Standardise the Engine Json RPC error codes #8671

mehdi-aouadi opened this issue Oct 2, 2024 · 0 comments
Labels
enhancement 🕵️‍♀️ New feature or request

Comments

@mehdi-aouadi
Copy link
Contributor

The json RPC error codes are standard: JSON-RPC 2.0 Specification
It would be better to handle the errors in the Web3JClient::doRequest based on their codes and avoid logging the whole stack trace:
Example: error code -32601 -> Method not found
@mehdi-aouadi mehdi-aouadi added the enhancement 🕵️‍♀️ New feature or request label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement 🕵️‍♀️ New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mehdi-aouadi