Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the engine get blobs method required #8669

Open
mehdi-aouadi opened this issue Oct 2, 2024 · 1 comment
Open

Make the engine get blobs method required #8669

mehdi-aouadi opened this issue Oct 2, 2024 · 1 comment

Comments

@mehdi-aouadi
Copy link
Contributor

mehdi-aouadi commented Oct 2, 2024

The current implementation of the engine_getBlobsV1 is marked as non critical and doesn't trigger an EL status update (in DefaultExecutionWeb3jClientProvider::buildClient) since it hasn't been implemented by all the ELs yet.
This should be removed from the non critical methods once it's implemented widely.
The required change:
Remove engine_getBlobsV1 from DefaultExecutionWeb3jClientProvider::buildClient

A new notion of optional execution RPC methods has also been added to handle the use case when an EL doesn't support the new method. This should be removed once all ELs have implemented it.
The required change:
Remove isOptional from EngineJsonRpcMethod
Remove MilestoneBasedEngineJsonRpcMethodsResolver::getOptionalCapabilities
Remove optionalCapabilitiesSupplier from EngineCapabilitiesMonitor

@tbenr
Copy link
Contributor

tbenr commented Oct 2, 2024

Regarding nonCritical, I think we should leave that method in the list.
Imagine a CL client has a bug only on engine_getBlobs: we can still work nicely.
Marking the EL as offline as a "critical" method, IIRC, has downstream affects on our overall availability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants