Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new JSON type #1430

Open
6 tasks
mshustov opened this issue Oct 30, 2024 · 3 comments · May be fixed by #1453
Open
6 tasks

Add support for new JSON type #1430

mshustov opened this issue Oct 30, 2024 · 3 comments · May be fixed by #1453
Assignees

Comments

@mshustov
Copy link
Member

mshustov commented Oct 30, 2024

Scope:

  • Variant type Add Variant Type #1436
  • Dynamic type
  • JSON type
  • Deprecation of Object('json')
  • performance benchmarking for string- and binary-based implementation
  • ch-go

from @SpencerTorres preliminary research

What works:

  • Inserting JSON as Go string
  • Selecting JSON when it is first cast to a string (::String). Must be scanned into a Go string type.
  • Selecting Dynamic column (from within a JSON object) when it is first cast to a string (::String). Must be scanned into a Go string type.

What doesn't work:

  • Inserting as Go json.RawMessage ([]byte) does not work (although I don't believe this works for String either)
  • Selecting does not work for non-casted JSON type column, the Go driver reports it as an unsupported type
  • Selecting does not work for non-casted Dynamic type column, the Go driver reports it as an unsupported type

Sample SQL:

SET allow_experimental_json_type = 1;

CREATE TABLE json_test (id String, obj JSON) Engine = MergeTree ORDER BY id;

INSERT INTO json_test (id, obj) VALUES ('a', '{ "key1": "value1", "nestedKey2": { "nestedValue2": 5 }, "arrayKey3": [4, 5, 6] }')

SELECT id, obj.key1, obj.nestedKey2, obj.arrayKey3, obj.nestedKey2.nestedValue2, obj FROM json_test;

Sample code:

// regular struct
type jsonRow struct {
	ID  string `ch:"id"`
	Obj string `ch:"obj"`
}

// row to insert, note that the JSON data is a `string`
var insertRow = jsonRow{
	ID:  "c",
	Obj: `{ "key1": "value1", "nestedKey2": { "nestedValue2": 5 }, "arrayKey3": [4, 5, 6] }`,
}

// async insert, blocking
err = db.AsyncInsert(context.Background(), "INSERT INTO json_test (id, obj) VALUES (?, ?)", true, insertRow.ID, insertRow.Obj)
if err != nil {
	fmt.Println(err)
	return
}

// This is where things break. The JSON column MUST be cast to a string here.
// Also renamed to fit struct tags.
// If the JSON column is not cast to string, the following error is printed: clickhouse: unsupported column type "JSON"
var rows []jsonRow
err = db.Select(context.Background(), &rows, "SELECT id, obj::String as obj FROM json_test")
if err != nil {
	fmt.Println(err)
	return
}

// Print object
fmt.Printf("%+v\n", rows)
// Output (formatted):
// [{
// 	ID: c
// 	Obj: {"arrayKey3":["4","5","6"],"key1":"value1","nestedKey2":{"nestedValue2":"5"}}
// }]

Example of selecting an object key in Grafana (which uses our latest Go driver):
grafana object select key

@stsmurf
Copy link

stsmurf commented Oct 31, 2024

Thanks for working on this! I was starting to use the new JSON data type today and AsyncInsert does work, however if attempting to use

err := db.PrepareBatch(context.Background(), "INSERT INTO json_test")

you will get the error unsupported column type "JSON" .

@lazharichir
Copy link

lazharichir commented Nov 21, 2024

SOLVED: only works by appending SETTINGS output_format_json_quote_64bit_integers = 0 to the query; the same user-level setting did nothing.

Leaving the original below for future readers/googlers...

It's also problematic that selecting a JSON or Dynamic column with UInt64 (i.e., golang's int or int64) results in a string being returned even if the JSON field has the UInt64 type.

This doesn't change when using SET output_format_json_quote_64bit_integers = 0;

You can see this in @mshustov's code snippet:

{ "key1": "value1", "nestedKey2": { "nestedValue2": 5 }, "arrayKey3": [4, 5, 6] }
becomes
{"arrayKey3":["4","5","6"],"key1":"value1","nestedKey2":{"nestedValue2":"5"}}

@SpencerTorres
Copy link
Member

SpencerTorres commented Dec 12, 2024

Found a bug that prevented enabling output_format_native_write_json_as_string=1, keep this in mind for other clients doing a string implementation. You'll need to update to a newer version

ClickHouse/ClickHouse#73179

This was referenced Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants