You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I am asking this because usually opentelemetry will need the propagator to inject or extract the span context instead of directly saving it under a struct or so.
Also, I believe in golang we'd better use the context itself to pass the span context as when starting a span, the span context should already be included in the golang context, directly passing the span context might not be a good way.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
I saw today we have this WithSpan function: https://github.com/ClickHouse/clickhouse-go/blob/main/context.go#L68
Are we using this to stitch client span with clickhouse server span for tracing purposes? Or just save the span to the clickhouse.
I am asking this because usually opentelemetry will need the propagator to inject or extract the span context instead of directly saving it under a struct or so.
Also, I believe in golang we'd better use the context itself to pass the span context as when starting a span, the span context should already be included in the golang context, directly passing the span context might not be a good way.
Beta Was this translation helpful? Give feedback.
All reactions