Various resources - missing mandatory/default fields

[benkelly12]

sdwan_service_lan_vpn_interface_ethernet_feature

ipv4_nat_type is mandatory in the API
Suggest making ipv4_nat_type = "pool" default

sdwan_service_routing_bgp_feature

Max number of prefixes is mandatory in the API but not in the resource

  address_families = [
    {
      family_type            = "ipv4-unicast"
      max_number_of_prefixes = 2000
      threshold              = 75
      policy_type            = "restart"
      restart_interval       = 30
    }
  ]

sdwan_transport_management_vpn_interface_ethernet_feature & sdwan_transport_wan_vpn_interface_ethernet_feature

these fields should be made mandatory fields, omitting them results in a 404 found error as they're used to generate the API endpoint
transport_management_vpn_feature_id
feature_profile_id

[seconroy]

Thank you for opening the issue, ipv4_nat_type and max_number_of_prefixes have variable options so we are unable to set them as mandatory. Reviewing the current documentation it is unclear that either ipv4_nat_type or ipv4_nat_type_variable need to be included and we need to figure out how this can reworked.

I'm currently looking into sdwan_transport_management_vpn_interface_ethernet_feature & sdwan_transport_wan_vpn_interface_ethernet_feature, from what I can recall there was a reason we didn't make feature_profile_id mandatory but I'm double checking