Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't produce mipmapped versions of atlases that don't use mipmaps #2941

Open
muzikbike opened this issue Dec 17, 2024 · 0 comments
Open

Don't produce mipmapped versions of atlases that don't use mipmaps #2941

muzikbike opened this issue Dec 17, 2024 · 0 comments
Labels
S-needs-triage Status: Needs triage T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link
Contributor

Request Description

Mipmapped versions of several atlases are generated, however there is no evidence that these are used by the game anywhere for any of the atlases besides the blocks atlas. Generating these wastes VRAM and costs extra time when loading resources.
Image

Affected atlases: armor trims, banner patterns, beds, chests, decorated pots, shield patterns, shulker boxes, signs

I'm 99% sure this is only the case since several of these were part of the main atlas in 1.15's development but were later split in the first prerelease, and Mojang didn't notice that these were redundantly generated.

If these are indeed used by the game I haven't knowingly seen the effects, since applying noisy textures to these objects and viewing them en masse from a distance and sharp angle causes all the grainy Moire patterns that mipmaps are designed to eliminate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-needs-triage Status: Needs triage T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

1 participant