Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better choices for fluid side textures #2928

Open
muzikbike opened this issue Dec 9, 2024 · 0 comments
Open

Better choices for fluid side textures #2928

muzikbike opened this issue Dec 9, 2024 · 0 comments
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement

Comments

@muzikbike
Copy link
Contributor

Request Description

This may be out of scope as a feature request as well as a change to vanilla behaviour which could also affect mods, however since #2471 is accepted as a valid candidate for fixing I suppose this may be worth bringing up as well since it touches on much the same area of code.

Currently, vanilla's application of textures to the sides of fluids is something I find strange. For source blocks, the downwards flowing texture is used, even if the fluid in question isn't actually flowing downwards. For water, if it's against certain solid blocks, the downwards flowing texture is replaced with a solid color translucent texture, which is easier on the eyes, but still feels like a suboptimal solution.

Bedrock Edition, in my opinion, does things much better: the sides of source blocks (provided they aren't flowing) is simply the still texture for that fluid. I think Sodium should replicate this behaviour.
2024-12-09_11 58 11
IMG_3692

Fluids that are flowing downwards would still use the downwards flowing texture, of course:
2024-12-09_12 06 48

Another issue is the side texture of horizontally-flowing fluids: it, too, appears to be flowing downwards. It would make much more sense for the texture to be instead rotated so that it's pointing in the flow direction, either left or right.
2024-12-09_12 05 27

Again, no idea if this is wildly out of scope even if it is close to a separate, valid issue, so tell me if I should or shouldn't open more tickets like this one.

@muzikbike muzikbike added S-needs-triage Status: Needs triage T-enhancement Type: Enhancement labels Dec 9, 2024
@jellysquid3 jellysquid3 added A-vanilla-issue Area: Vanilla issue and removed S-needs-triage Status: Needs triage labels Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-vanilla-issue Area: Vanilla issue T-enhancement Type: Enhancement
Projects
None yet
Development

No branches or pull requests

2 participants