Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl-C doesn't exit slow_cooker quickly enough #17

Open
stevej opened this issue Jul 22, 2016 · 1 comment
Open

Ctrl-C doesn't exit slow_cooker quickly enough #17

stevej opened this issue Jul 22, 2016 · 1 comment

Comments

@stevej
Copy link
Contributor

stevej commented Jul 22, 2016

From oliver:

for some reason i can’t Ctrl-C slowcooker
it stops sending traffic but doesn’t close down

William noted that we aren't capturing syscall.SIGTERM, only syscall.SIGINT. I don't think we should catch SIGTERM. Most terminals send SIGINT on Ctrl-C so I think the existing trap is sufficient but we need to figure out what's not draining properly.
@stevej
Copy link
Contributor Author

stevej commented Jul 25, 2016

oliver noted that he sees this on the Mac.

aasssddd pushed a commit to aasssddd/slow_cooker that referenced this issue Oct 17, 2017
@tnachen
Merge pull request BuoyantIO#17 from aasssddd/multiple_payload
d11e8a1 
remove TODO comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stevej