Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'time array', vertical units, and python 3 ? #1

Open
marcocamma opened this issue Sep 22, 2017 · 0 comments
Open

'time array', vertical units, and python 3 ? #1

marcocamma opened this issue Sep 22, 2017 · 0 comments

Comments

@marcocamma
Copy link

Hi,

thanks very much for sharing your very nice module (I have only been using lecroy.py).
Few comments below:

  1. ===============
    If I have not mistaken, it takes some typing' to get time axis (from the wave descriptor):

    desc,sig = scope.get_waveform(1)
    t = np.arange(desc['pnts_per_screen']+1)*desc['horiz_interval]+desc['horiz_offset']

Would it make sense to have a method like the one below ?

scope.get_horaxis(channel)

  1. ===============
    Similarly, it may be convenient to have the vertical axis in V.
    It could be done with a keyword argument of the get_waveform method.

  2. ===============
    Last point, it would be nice to have python3 support. For what I have seen it should be relatively easy to do.

I could help if you are interested in for any of the three points,
thanks,
marco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcocamma