Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version with compiler-manager enabled causes many rc cmds to not work #1405

Open
mckellygit opened this issue Dec 20, 2020 · 5 comments

Comments

@mckellygit
Copy link

mckellygit commented Dec 20, 2020

Hi,
Thank you for rtags, it is awesome.
I just built the latest version and found all my rc commands to find references, go to definitions, etc. no longer work.
I disabled the compiler-manager and every cmd now works great as before.
Perhaps this is correct - but I just wanted to ask about what specifically the compiler manager changes ?
Does this suggest my compiler is not installed/configured correctly ?
thx again.
-m

@vkargov
Copy link

vkargov commented Dec 23, 2020

Disabling the compiler manager with --disable-compiler-manager fixed some of the mysterious rtags failures for me, too, thanks for sharing your finding!

To clarify, with -R which is now default in the latest Git version, rtags couldn't find a file function definition in an include file even though the include file itself was marked as indexed, e.g.:

// lib.h
int myfunc() {...}
// main.cpp
#include "lib.h"
int main() {
  ...
  myfunc();
  ...
}

@vkargov
Copy link

vkargov commented Dec 23, 2020

I'll try to clarify the purpose of the compiler manager, though I'm not very conversant with the RTags project myself.
The compiler manager queries the compilers that build your program to supply some additional flags that were provided by the build system or the developer that may affect the location of some of the include files.
For instance, if clang++ is called with -isysroot or --sysroot during your build, then rtags may not find the location of some include files in those directories without --enable-compiler-manager. Google Chrome builds do that, for example, and for them the compiler manager is a good option that helps rtags find and index the right header files.
I have no idea why it fails under some circumstances!

@mckellygit
Copy link
Author

@vkargov thank you. I suppose we can close this issue now ?

@vkargov
Copy link

vkargov commented Dec 26, 2020

I suppose we can close this issue now ?

Personally I'd love to see it open since the problem is there and has not been fixed. Perhaps someone could explain why using a compiler manager causes such apparent regression.

@mckellygit
Copy link
Author

ok, I will leave it open and we can see if anyone else has comments.
thx,
-m

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants