Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Camera Drivers #39

Open
waltermwaniki opened this issue Jun 26, 2024 · 1 comment
Open

Refactor Camera Drivers #39

waltermwaniki opened this issue Jun 26, 2024 · 1 comment
Assignees

Comments

@waltermwaniki
Copy link
Collaborator

Issue
Base Camera and subsequently device specific Camera drivers do not inherit from the base VoxelDevice class.
Base Camera should subclass ABC and utilize @abstractmethod to enforce a clear blueprint for voxel compliant cameras.

Solution
Refactor the base camera class.
Refactor individual camera drivers to implement the new base camera class.

@waltermwaniki waltermwaniki self-assigned this Jun 26, 2024
@waltermwaniki
Copy link
Collaborator Author

@adamkglaser
I'm trying to resolve the methods and properties that should be listed in the camera base class. I have put together a markdown file in the cameras folder that lists these out. Hoping you can take a look and give me feedback. I left out some properties at the bottom of the readme file that I'm most unsure of.
Currently working in the following branch: Camera refactor 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant