Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DrCovModule is exclusive to user-mode #2572

Open
vringar opened this issue Sep 30, 2024 · 3 comments · May be fixed by #2573
Open

DrCovModule is exclusive to user-mode #2572

vringar opened this issue Sep 30, 2024 · 3 comments · May be fixed by #2573
Labels
bug Something isn't working

Comments

@vringar
Copy link
Contributor

vringar commented Sep 30, 2024

The issue exists in 17def03

Describe the bug

Previously the QemuDrCovHelper could be used in Systemmode and was critical to the way we worked.
#2267 moved the DrCovModule into the usermode module making it inaccessible for our usecase.

To Reproduce
Steps to reproduce the behavior:

  1. Look where drcov.rs is in the tree
  2. See the conditional inclusion of this module

Expected behavior

I expect this module to be available in systemmode as well.

Additional context

I'm sorry if there is a technical reason why this only works in usermode, I'll move the DrCovModule to the generic modules and see what happens. However, I still wanted to open the issue, so maybe you can tell me, why I shouldn't do this.

@vringar vringar added the bug Something isn't working label Sep 30, 2024
@rmalmain
Copy link
Collaborator

sorry, it's a mistake on my end. I'll fix asap

@rmalmain rmalmain linked a pull request Sep 30, 2024 that will close this issue
@vringar
Copy link
Contributor Author

vringar commented Sep 30, 2024

Thank you so much!

@rmalmain
Copy link
Collaborator

no worries, thanks for pointing out the issue! once the ci is happy i'll merge the patch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants