Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Connect sidecar of Operator #68

Open
villesau opened this issue Aug 13, 2021 · 2 comments
Open

Make Connect sidecar of Operator #68

villesau opened this issue Aug 13, 2021 · 2 comments
Labels
tracked Issue is tracked in 1Password's internal ticketing system as well.

Comments

@villesau
Copy link

villesau commented Aug 13, 2021

Summary

Making Connect sidecar of the Operator would limit the Connect scope to inside pod, which in turn would mean that no ports would need to be opened outside the pod. This would limit the risk of misconfiguration and exposing the Connect too widely accidentally.

Use cases

When you only need Connect for serving Operator. For example I only need Connect to serve the Operator so I don't need the endpoints to be exposed to anything else. I would sleep my nights better if it were abstracted away.

Proposed solution

Implement a possibility to make Connect sidecar of Operator

Is there a workaround to accomplish this today?

Not that I know.

E: Actually this is exactly the reason why I'd rather keep the Connect as a sidecar for the Operator: #65 It is too easy to expose the endpoints to external world.

@jillianwilson
Copy link
Contributor

Thanks for reaching out. I think there are use cases for both running 1Password Connect run from outside of the Connect Operator or as a separate sidecar so I think it might be nice to have an optional field in the helm chart to deploy as a sidecar rather than in a separate pod. We will look into potentially implementing this in the future.

@villesau
Copy link
Author

Yes an option would probably make sense in this case since if the connect is used for something else than the operator only, sidecar is not that good option. But if it is used solely for the operator, it would isolate the connect well and thus reducing the risk factor significantly as well as make the setup simpler.

@edif2008 edif2008 added the tracked Issue is tracked in 1Password's internal ticketing system as well. label May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracked Issue is tracked in 1Password's internal ticketing system as well.
Projects
None yet
Development

No branches or pull requests

3 participants