Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support configuring PKI #1

Open
kyrias opened this issue Nov 22, 2016 · 4 comments
Open

Support configuring PKI #1

kyrias opened this issue Nov 22, 2016 · 4 comments

Comments

@kyrias
Copy link

kyrias commented Nov 22, 2016

It would be useful to have support for configuring a PKI for TLS support.

@0xf10e
Copy link
Owner

0xf10e commented Nov 23, 2016 via email

@kyrias
Copy link
Author

kyrias commented Nov 23, 2016

The pki statements required to set up TLS listens, yeah. Though while trying to make this formula a bit more complete I ended up replacing the config file with one rendered from a python module. You can take a look at it here if you want to see if it's something you would consider merging.

@0xf10e
Copy link
Owner

0xf10e commented Dec 3, 2016

I first thought you used some external module but the #!py renderer would be fine.

But before merging we'd need to sort out two things:

  • You're using absolute paths in your template
  • I think when switching from the jinja-based defaults file you removed the standard merging logic with pillar lookups

I haven't looked closely enough at your changes yet to see if you reintroduced the merging logic later.

@kyrias
Copy link
Author

kyrias commented Dec 3, 2016

Yeah, I'm at an impasse when it comes to the template, because there seems to be no python function for loading a function.

Anyway, with regards to the defaults file, I did that because I've never seen anyone do it like that before, because it seems rather pointless? Generally you just have a static yaml file with the defaults, because they're just the general defaults, and then the map file merges that in.

(Solved the problem with the relative path loading now.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants